Do not re-open menu when it's already invisible

[juskevicius]

One more bug with requestAnimationFrame that is executed asynchronously.
The issue is that requestAnimationFrame callback might be executed after a while, when the state has changed and the component is no longer visible (state.isVisible is false). The outcome - the menu gets closed, but then is immediately re-opened.

Can reproduce the bug with this test (run in ContextMenu.test.js file):

    test('hides the menu but then reopens incorrectly', async () => {
        const data = { position: { x: 50, y: 50 }, id: 'CORRECT_ID' };
        const { rerender } = render(<ContextMenu id={data.id} hideOnLeave />);
        const user = userEvent.setup();

        await showMenu(data);

        // trigger re-render -> componentDidUpdate -> schedule requestAnimationFrame to set opacity to 1:
        rerender(<ContextMenu id={data.id} hideOnLeave />); 
        
        // trigger menu hide:
        await user.click(document.body);
        // menu is hidden, opacity is set to 0 - OK:
        await waitFor(() => expect(contextMenuElement()).not.toBeVisible());

        // requestAnimationFrame is finally called, opacity is set to 1 again - NOT OK:
        await waitFor(() => expect(contextMenuElement()).toBeVisible());
    });

Solution: check for visibility state in the callback itself

[netlify]

✅ Deploy Preview for firefox-devtools-react-contextmenu ready!

Name	Link
🔨 Latest commit	903fcc7
🔍 Latest deploy log	https://app.netlify.com/sites/firefox-devtools-react-contextmenu/deploys/67c97cd2285ad40008df013c
😎 Deploy Preview	https://deploy-preview-292--firefox-devtools-react-contextmenu.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 Accessibility: 82 Best Practices: 92 SEO: 92 PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[julienw]

Thanks, this looks good to me!

I remember that in the past I had to workaround some issues that might be related to that actually... :-)