Documentation and cleaning up the publishing process#301
Merged
julienw merged 2 commits intofirefox-devtools:masterfrom Mar 24, 2025
Merged
Documentation and cleaning up the publishing process#301julienw merged 2 commits intofirefox-devtools:masterfrom
julienw merged 2 commits intofirefox-devtools:masterfrom
Conversation
…make sure we update dependencies before building
✅ Deploy Preview for firefox-devtools-react-contextmenu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
canova
approved these changes
Mar 24, 2025
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Looks good to me. I don't remember having to disable the branch protection part. So it's good to have this. I was thinking if we can do the same thing without it, but probably this is easier to do.
I usually push my tags with git push upstream --tags without the HEAD so it only pushes the tags, but I forgot the commit that publish generates. We still need to push it somehow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some documentation about the publishing process.
This also changes the script
prepublishOnlytoprepackwhen publishing. Both are run currently so it's really a no-op, but I've noticed that more recent versions of yarn only doesprepack, so this looks more correct.I also updated the content of this script to make sure the dependencies are uptodate before building.