fix(soundness): fix a soundness bug with the Maybe<T> type and the HasSchema derive macro for generic types.#456
Merged
MaxCWhitehead merged 1 commit intofishfolk:mainfrom Sep 8, 2024
Conversation
…HasSchema derive macro for generic types. There was a bug in the HasSchema derive macro for generic types, where the enum variant schema was returning the schema for a previously computed instantiation of the generic type, instead of specializing based on the Rust type ID. This fixes that, fixing undefined behavior that may be triggered when using `Maybe<T>` along with any other generic enums that have derived HasSchema.
MaxCWhitehead
approved these changes
Sep 8, 2024
RockasMockas
pushed a commit
to RockasMockas/bones
that referenced
this pull request
Sep 9, 2024
…`HasSchema` derive macro for generic types. (fishfolk#456) There was a bug in the `HasSchema` derive macro for generic types, where the enum variant schema was returning the schema for a previously computed instantiation of the generic type, instead of specializing based on the Rust type ID. This fixes that, fixing undefined behavior that may be triggered when using `Maybe<T>` along with any other generic enums that have derived `HasSchema`. This should also fix fishfolk#296, which I can't reproduce right now, but could have been caused randomly by `Maybe::schema()` being unsound. Fixes: fishfolk#296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the
HasSchemaderive macro for generic types, where the enum variant schema was returning the schema for a previously computed instantiation of the generic type, instead of specializing based on the Rust type ID.This fixes that, fixing undefined behavior that may be triggered when using
Maybe<T>along with any other generic enums that have derivedHasSchema.This should also fix #296, which I can't reproduce right now, but could have been caused randomly by
Maybe::schema()being unsound.Fixes: #296