Merged
Conversation
Member
Author
|
I just realized that you guys already had a set of item specifications to implement. Whoops. 🙃 That makes more sense. Well there's this one if you want it, but I'll work on a couple of the ones from your list, too. 🙂 Edit: And I see there's already a trident in there, too, but with more advanced functionality. You guys have some good ideas. :) I'll close this in favor of items from the existing specs. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks! I got the assignment from @erlend-sh to make at least 2 weapons, so here's the first one. ( Thanks to @TekhnaeRaav for the idea to make a trident ).
The sprite is just a placeholder, of course.
simplescreenrecorder-2022-04-04_19.24.58.mp4
I'm not 100% sure how you guys want to balance the weapons, but the trident currently swings faster than a sword, and the damage zone doesn't cover your own body, just the area in front, so it's got more of a spear behavior than the sword.
I think it measures more powerful than the sword in general, but still probably worse than most guns.
Also, I noticed that when laying on the ground and facing to the left, the sprites bounding box isn't quite right:
It turns out that the other weapons for the most part don't have a lot of empty space in the sprites on the x axis, so it's almost un-noticeable, but the trident has a lot of extra horizontal room for the stab animation so it get's harder to pick up the trident when it's facing left.
I'm assuming that should be tackled as a separate PR/issue, but if you want I can look into fixing it.