Skip to content

Add Item: Trident#409

Merged
olefasting merged 1 commit intofishfolk:mainfrom
zicklag:feature/trident
Apr 6, 2022
Merged

Add Item: Trident#409
olefasting merged 1 commit intofishfolk:mainfrom
zicklag:feature/trident

Conversation

@zicklag
Copy link
Copy Markdown
Member

@zicklag zicklag commented Apr 5, 2022

Hey folks! I got the assignment from @erlend-sh to make at least 2 weapons, so here's the first one. ( Thanks to @TekhnaeRaav for the idea to make a trident ).

The sprite is just a placeholder, of course.

simplescreenrecorder-2022-04-04_19.24.58.mp4

I'm not 100% sure how you guys want to balance the weapons, but the trident currently swings faster than a sword, and the damage zone doesn't cover your own body, just the area in front, so it's got more of a spear behavior than the sword.

I think it measures more powerful than the sword in general, but still probably worse than most guns.

Also, I noticed that when laying on the ground and facing to the left, the sprites bounding box isn't quite right:

image

image

It turns out that the other weapons for the most part don't have a lot of empty space in the sprites on the x axis, so it's almost un-noticeable, but the trident has a lot of extra horizontal room for the stab animation so it get's harder to pick up the trident when it's facing left.

I'm assuming that should be tackled as a separate PR/issue, but if you want I can look into fixing it.

@zicklag
Copy link
Copy Markdown
Member Author

zicklag commented Apr 5, 2022

I just realized that you guys already had a set of item specifications to implement. Whoops. 🙃 That makes more sense.

Well there's this one if you want it, but I'll work on a couple of the ones from your list, too. 🙂

Edit: And I see there's already a trident in there, too, but with more advanced functionality. You guys have some good ideas. :)

I'll close this in favor of items from the existing specs.

@zicklag zicklag closed this Apr 5, 2022
@erlend-sh
Copy link
Copy Markdown
Member

Whoops, I forgot to link to the standard list of Items.

However, I don’t think we’ve implemented #149 so you can go ahead with that as well.

@erlend-sh erlend-sh reopened this Apr 5, 2022
@olefasting olefasting merged commit 537f5b8 into fishfolk:main Apr 6, 2022
@zicklag zicklag deleted the feature/trident branch April 6, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants