Make Eaiser to Create Animated Sprites From Meta#413
Merged
olefasting merged 1 commit intofishfolk:mainfrom Apr 12, 2022
Merged
Make Eaiser to Create Animated Sprites From Meta#413olefasting merged 1 commit intofishfolk:mainfrom
olefasting merged 1 commit intofishfolk:mainfrom
Conversation
`impl From<AnimatedSpriteMetadata> for Animated Sprite` and clean up some of the code that could benefit from it.
zicklag
force-pushed
the
animated-sprites-from-meta
branch
from
5f045d3 to
e5c5db3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impl From<AnimatedSpriteMetadata> for Animated Spriteand cleanup some of the code that could benefit from it.
This is just some cleaning up I did while working on some effect stuff and I thought it'd be good to keep in a separate PR for ease of review.