Kill Fish When They Fall Out of Bounds#429
Merged
olefasting merged 1 commit intofishfolk:mainfrom Jun 2, 2022
Merged
Conversation
Member
Author
|
Should I be basing any of my pull requests off of |
orhun
approved these changes
May 24, 2022
Member
No, I am in the process of remergin and it will be easier for me just to add in your code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where, on levels that you can fall off of, the fish falls off and continues falling forever without dying.
Also, it addresses the issue where the camera try to adjust to follow the falling fish outside of the play area, causing issues with parallax backgrounds.
Before:
After:
