[Merged by Bors] - feat: add kick_bomb to jumpy core.#568
Closed
HexSleeves wants to merge 6 commits intofishfolk:mainfrom
Closed
[Merged by Bors] - feat: add kick_bomb to jumpy core.#568HexSleeves wants to merge 6 commits intofishfolk:mainfrom
HexSleeves wants to merge 6 commits intofishfolk:mainfrom
Conversation
Contributor
Author
|
Old Camera:
|
Member
|
Sweet! I might not get reviewing tonight, but I'll check as soon as I can. Also, quick question, at the end of your video the screen went solid colored. Did you not re-spawn or something? I've never seen that happen. You usually respawn. |
Contributor
Author
|
It seems i did not respawn. I can do a deeper dive to see why |
HexSleeves
commented
Jan 18, 2023
HexSleeves
force-pushed
the
feat_kick_bomb
branch
from
9a4f364 to
6d4c717
Compare
zicklag
changed the title
Contributor
Author
|
Kick bombs can now be kicked (disregard the camera mixup, i didnt pull from main yet) jumpy_zVJ5ZNWiag.mp4 |
zicklag
requested changes
Jan 18, 2023
Member
zicklag
left a comment
zicklag
left a comment
There was a problem hiding this comment.
Great!
Just a couple things:
- Could you fix the clippy errors.
- Could you move either the grenade or the kick bomb spawn point on level 1 so that they aren't in the same spot when they spawn.
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Migrates the kick_bomb from before the bones_ecs merge.
Contributor
|
Build failed: |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Migrates the kick_bomb from before the bones_ecs merge.
Contributor
|
Build failed:
|
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Migrates the kick_bomb from before the bones_ecs merge.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the kick_bomb from before the bones_ecs merge.