Skip to content

Remove room_id #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AHGIJMKLKKZNPJKQR merged 2 commits into from
Aug 14, 2025
Merged

Remove room_id #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf10d7
Remove room_id
AHGIJMKLKKZNPJKQR Aug 14, 2025
4c68473
Remove peer_id from response
AHGIJMKLKKZNPJKQR Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions doc/docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ Request sent by agent, to authenticate to Fishjam server
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| token | [string](#string) | | |
| room_id | [string](#string) | | |



Expand Down Expand Up @@ -240,11 +239,6 @@ Defines any type of message passed from Fishjam to agent peer
Response confirming successful authentication


| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| peer_id | [string](#string) | | The Peer ID assigned to the connected Agent |





Expand Down
6 changes: 1 addition & 5 deletions fishjam/agent_notifications.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ message AgentRequest {
// Request sent by agent, to authenticate to Fishjam server
message AuthRequest {
string token = 1;
string room_id = 2;
}

// Request to add a track of the specified type
Expand Down Expand Up @@ -51,10 +50,7 @@ message AgentRequest {
// Defines any type of message passed from Fishjam to agent peer
message AgentResponse {
// Response confirming successful authentication
message Authenticated {
// The Peer ID assigned to the connected Agent
string peer_id = 1;
}
message Authenticated {}

// Notification containing a chunk of a track's data stream
message TrackData {
Expand Down
3 changes: 0 additions & 3 deletions fishjam_protos/lib/fishjam/agent_notifications.pb.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ defmodule Fishjam.AgentRequest.AuthRequest do
use Protobuf, protoc_gen_elixir_version: "0.15.0", syntax: :proto3

field :token, 1, type: :string
field :room_id, 2, type: :string, json_name: "roomId"
end

defmodule Fishjam.AgentRequest.AddTrack.CodecParameters do
Expand Down Expand Up @@ -72,8 +71,6 @@ defmodule Fishjam.AgentResponse.Authenticated do
@moduledoc false

use Protobuf, protoc_gen_elixir_version: "0.15.0", syntax: :proto3

field :peer_id, 1, type: :string, json_name: "peerId"
end

defmodule Fishjam.AgentResponse.TrackData do
Expand Down
Loading