Skip to content

Add peer type #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roznawsk merged 2 commits into from
Aug 22, 2025
Merged

Add peer type #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d9c9dc
Add peer type
roznawsk Aug 21, 2025
4188b56
Doc + package
roznawsk Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions doc/docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
- [ServerMessage.ViewerDisconnected](#fishjam-ServerMessage-ViewerDisconnected)

- [ServerMessage.EventType](#fishjam-ServerMessage-EventType)
- [ServerMessage.PeerType](#fishjam-ServerMessage-PeerType)

- [fishjam/shared_notifications.proto](#fishjam_shared_notifications-proto)
- [Track](#fishjam-Track)
Expand Down Expand Up @@ -1277,6 +1278,7 @@ Notification sent when a peer is added
| ----- | ---- | ----- | ----------- |
| room_id | [string](#string) | | |
| peer_id | [string](#string) | | |
| peer_type | [ServerMessage.PeerType](#fishjam-ServerMessage-PeerType) | | |



Expand All @@ -1293,6 +1295,7 @@ Notification sent when a peer connects
| ----- | ---- | ----- | ----------- |
| room_id | [string](#string) | | |
| peer_id | [string](#string) | | |
| peer_type | [ServerMessage.PeerType](#fishjam-ServerMessage-PeerType) | | |



Expand All @@ -1310,6 +1313,7 @@ Notification sent when a peer crashes
| room_id | [string](#string) | | |
| peer_id | [string](#string) | | |
| reason | [string](#string) | | |
| peer_type | [ServerMessage.PeerType](#fishjam-ServerMessage-PeerType) | | |



Expand All @@ -1326,6 +1330,7 @@ Notification sent when a peer is removed
| ----- | ---- | ----- | ----------- |
| room_id | [string](#string) | | |
| peer_id | [string](#string) | | |
| peer_type | [ServerMessage.PeerType](#fishjam-ServerMessage-PeerType) | | |



Expand All @@ -1342,6 +1347,7 @@ Notification sent when a peer disconnects from FJ
| ----- | ---- | ----- | ----------- |
| room_id | [string](#string) | | |
| peer_id | [string](#string) | | |
| peer_type | [ServerMessage.PeerType](#fishjam-ServerMessage-PeerType) | | |



Expand Down Expand Up @@ -1569,6 +1575,19 @@ Defines message groups for which peer can subscribe
| EVENT_TYPE_SERVER_NOTIFICATION | 1 | |



<a name="fishjam-ServerMessage-PeerType"></a>

### ServerMessage.PeerType


| Name | Number | Description |
| ---- | ------ | ----------- |
| PEER_TYPE_UNSPECIFIED | 0 | |
| PEER_TYPE_WEBRTC | 1 | |
| PEER_TYPE_AGENT | 2 | |





Expand Down
11 changes: 11 additions & 0 deletions fishjam/server_notifications.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,35 +11,46 @@ message ServerMessage {
string room_id = 1;
}

enum PeerType {
PEER_TYPE_UNSPECIFIED = 0;
PEER_TYPE_WEBRTC = 1;
PEER_TYPE_AGENT = 2;
}

// Notification sent when a peer is added
message PeerAdded {
string room_id = 1;
string peer_id = 2;
PeerType peer_type = 3;
}

// Notification sent when a peer is removed
message PeerDeleted {
string room_id = 1;
string peer_id = 2;
PeerType peer_type = 3;
}

// Notification sent when a peer connects
message PeerConnected {
string room_id = 1;
string peer_id = 2;
PeerType peer_type = 3;
}

// Notification sent when a peer disconnects from FJ
message PeerDisconnected {
string room_id = 1;
string peer_id = 2;
PeerType peer_type = 3;
}

// Notification sent when a peer crashes
message PeerCrashed {
string room_id = 1;
string peer_id = 2;
string reason = 3;
PeerType peer_type = 4;
}

// Notification sent when a component crashes
Expand Down
15 changes: 15 additions & 0 deletions fishjam_protos/lib/fishjam/server_notifications.pb.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
defmodule Fishjam.ServerMessage.PeerType do
@moduledoc false

use Protobuf, enum: true, protoc_gen_elixir_version: "0.15.0", syntax: :proto3

field :PEER_TYPE_UNSPECIFIED, 0
field :PEER_TYPE_WEBRTC, 1
field :PEER_TYPE_AGENT, 2
end

defmodule Fishjam.ServerMessage.EventType do
@moduledoc false

Expand All @@ -22,6 +32,7 @@ defmodule Fishjam.ServerMessage.PeerAdded do

field :room_id, 1, type: :string, json_name: "roomId"
field :peer_id, 2, type: :string, json_name: "peerId"
field :peer_type, 3, type: Fishjam.ServerMessage.PeerType, json_name: "peerType", enum: true
end

defmodule Fishjam.ServerMessage.PeerDeleted do
Expand All @@ -31,6 +42,7 @@ defmodule Fishjam.ServerMessage.PeerDeleted do

field :room_id, 1, type: :string, json_name: "roomId"
field :peer_id, 2, type: :string, json_name: "peerId"
field :peer_type, 3, type: Fishjam.ServerMessage.PeerType, json_name: "peerType", enum: true
end

defmodule Fishjam.ServerMessage.PeerConnected do
Expand All @@ -40,6 +52,7 @@ defmodule Fishjam.ServerMessage.PeerConnected do

field :room_id, 1, type: :string, json_name: "roomId"
field :peer_id, 2, type: :string, json_name: "peerId"
field :peer_type, 3, type: Fishjam.ServerMessage.PeerType, json_name: "peerType", enum: true
end

defmodule Fishjam.ServerMessage.PeerDisconnected do
Expand All @@ -49,6 +62,7 @@ defmodule Fishjam.ServerMessage.PeerDisconnected do

field :room_id, 1, type: :string, json_name: "roomId"
field :peer_id, 2, type: :string, json_name: "peerId"
field :peer_type, 3, type: Fishjam.ServerMessage.PeerType, json_name: "peerType", enum: true
end

defmodule Fishjam.ServerMessage.PeerCrashed do
Expand All @@ -59,6 +73,7 @@ defmodule Fishjam.ServerMessage.PeerCrashed do
field :room_id, 1, type: :string, json_name: "roomId"
field :peer_id, 2, type: :string, json_name: "peerId"
field :reason, 3, type: :string
field :peer_type, 4, type: Fishjam.ServerMessage.PeerType, json_name: "peerType", enum: true
end

defmodule Fishjam.ServerMessage.ComponentCrashed do
Expand Down
Loading