Conversation
Karolk99
force-pushed
the
media-events-no-simulcast
branch
from
a51e9d8 to
0f7d4ce
Compare
roznawsk
requested changes
Oct 29, 2024
roznawsk
reviewed
Oct 29, 2024
roznawsk
approved these changes
Oct 30, 2024
kamil-stasiak
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposition of a protobuf standardization of media events without simulcast.
Right now, the
Metadatafield is defined inshared.protoand requires passing under thejsonfield parsed json. This is easy to use but requires encoding and decoding JSON. Alternatively, we can usegoogle.protobuf.Structtype but I'm not sure it's better and we would have to test if elixir supports it.