Conversation
roznawsk
force-pushed
the
simulcast
branch
2 times, most recently
from
94b10c5 to
d61a635
Compare
roznawsk
force-pushed
the
simulcast
branch
2 times, most recently
from
598e8b8 to
e8e6a00
Compare
Karolk99
requested changes
Nov 22, 2024
| @@ -43,7 +50,19 @@ message MediaEvent { | |||
| // Sent when Peer wants to update its track's bitrate | |||
| message TrackBitrate { | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| message TrackBitrate { | |
| message TrackBitrates { |
| repeated media_events.Variant disabled_variants = 3; | ||
| } | ||
|
|
||
| string track_id = 1; |
Collaborator
There was a problem hiding this comment.
track_id is not needed as it's map now
Suggested change
| string track_id = 1; |
| // Defines any type of message sent from Membrane RTC Engine to Peer | ||
| message MediaEvent { | ||
| // SCHEMAS | ||
| message Track { |
Collaborator
There was a problem hiding this comment.
all occurence of map<string, string> track_id_to_metadata_json should probably be map<string, Track> track_id_to_track
Karolk99
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minimal set of simulcast messages, allowing for sending simulcast tracks, and receiving them with manual variant selection.
I propose only providing bitrates for simulcast tracks. The bitrate values in Engine are used solely for calculating the appropriate variant sent to other peers. So any bitrate values sent for non-simulcast tracks are just ignored.
I also removed
Reasonfrom theVariantSwitchedmessage. The reason is not used in Web Client and its only role (if any) would be to provide feedback to users, which is not important.