Merged
Conversation
roznawsk
reviewed
Nov 8, 2024
Member
roznawsk
left a comment
roznawsk
left a comment
There was a problem hiding this comment.
Looks good, as discussed IRL we may consider adding a check that ensures that the files in Elixir are up to date
Karolk99
force-pushed
the
release-fishjam-protos-action
branch
3 times, most recently
from
0571c20 to
bd81e27
Compare
Karolk99
force-pushed
the
release-fishjam-protos-action
branch
from
bd81e27 to
24d0a06
Compare
roznawsk
approved these changes
Nov 8, 2024
| echo "Generated protobuf files are not up to date. Please regenerate them and commit the changes." | ||
| git diff | ||
| exit 1 | ||
| fi No newline at end of file |
| env: | ||
| HEX_API_KEY: ${{ secrets.MIX_HEX_KEY }} | ||
| run: mix hex.publish --yes | ||
| working-directory: fishjam_protos No newline at end of file |
| [ | ||
| inputs: ["{mix,.formatter}.exs", "{config,lib,test}/**/*.{ex,exs}"] | ||
| inputs: ["{mix,.formatter}.exs", "{config,lib,test}/**/*.{ex,exs}"], | ||
| locals_without_parens: [field: 1, field: 2, field: 3, field: 4, oneof: 1, oneof: 2] |
Member
There was a problem hiding this comment.
Maybe instead we could import this config from protobuf package:
import_deps: [:protobuf] ?
Karolk99
force-pushed
the
release-fishjam-protos-action
branch
from
d210e66 to
ff2af33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.