Skip to content

Update server notification example in README.md#12

Merged
LVala merged 1 commit intomasterfrom
proto-fixes
May 16, 2023
Merged

Update server notification example in README.md#12
LVala merged 1 commit intomasterfrom
proto-fixes

Conversation

@LVala
Copy link
Copy Markdown
Collaborator

@LVala LVala commented May 15, 2023

I didn't add the include_docs=true option to protoc because it looked quite confusing in the docs and didn't pass mix credo, I think it's better to simply link to the file.

@LVala LVala requested a review from mickel8 May 15, 2023 10:45
@LVala LVala self-assigned this May 15, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2023

Codecov Report

Merging #12 (d91ed81) into master (e19b1dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files           7        7           
  Lines         113      113           
=======================================
  Hits           76       76           
  Misses         37       37           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19b1dd...d91ed81. Read the comment docs.

@LVala LVala merged commit d05f92c into master May 16, 2023
@LVala LVala deleted the proto-fixes branch May 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants