Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 74.59% 72.88% -1.71%
==========================================
Files 8 8
Lines 122 118 -4
==========================================
- Hits 91 86 -5
- Misses 31 32 +1
Continue to review full report in Codecov by Sentry.
|
roznawsk
approved these changes
Jun 16, 2023
Member
roznawsk
left a comment
roznawsk
left a comment
There was a problem hiding this comment.
Looks, great 🥇 . I added a single comment, referring to my latest PR.
Comment on lines
18
to
19
| %Jellyfish.Peer{id: "5a731f2e-f49f-4d58-8f64-16a5c09b520e", type: Jellyfish.Peer.WebRTC}, | ||
| "3LTQ3ZDEtYTRjNy0yZDQyZjU1MDAxY2FkAAdyb29tX2lkbQAAACQ0M"} |
Member
There was a problem hiding this comment.
I should've changed this before.
Suggested change
| %Jellyfish.Peer{id: "5a731f2e-f49f-4d58-8f64-16a5c09b520e", type: Jellyfish.Peer.WebRTC}, | |
| "3LTQ3ZDEtYTRjNy0yZDQyZjU1MDAxY2FkAAdyb29tX2lkbQAAACQ0M"} | |
| %Jellyfish.Peer{ | |
| id: "65174802-7b1c-4dfd-b902-106958067337", | |
| type: :webrtc, | |
| status: :disconnected | |
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed invalid docs, added new docker test setup (similar to the one in
jellyfish_videoroomand changed peer/component type (when e.g. listing rooms) from e.g.:webrtctoJellyfish.Peer.WebRTCto be consistent with the rest of the API.