Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 80.54% 80.64% +0.10%
==========================================
Files 9 9
Lines 185 186 +1
==========================================
+ Hits 149 150 +1
Misses 36 36
Continue to review full report in Codecov by Sentry.
|
| @spec start_link(options()) :: | ||
| {:ok, pid()} | {:error, term()} |
There was a problem hiding this comment.
This should fit into one line, shouldn't it? The same for start/1
| server_api_token: "your-jellyfish-token", | ||
| secure?: true | ||
| ``` | ||
| First, [configure the connection options](https://hexdocs.pm/jellyfish_server_sdk/readme.html#jellyfish-connection-configuration). |
There was a problem hiding this comment.
I would prefer not to redirect to the README
There was a problem hiding this comment.
Maybe it would be nicer to put the description in Client moduledoc?
| secure?: true | ||
| ``` | ||
|
|
||
| Alternatively, the connection options can be provided when creating a `Jellyfish.Client` or starting `Jellyfish.Notifier` instead of using config: |
There was a problem hiding this comment.
| Alternatively, the connection options can be provided when creating a `Jellyfish.Client` or starting `Jellyfish.Notifier` instead of using config: | |
| Alternatively, the connection options can be provided when creating a `Jellyfish.Client` or starting `Jellyfish.Notifier`: |
| server_api_token: "your-jellyfish-token", | ||
| secure?: true | ||
| ``` | ||
| First, [configure the connection options](https://hexdocs.pm/jellyfish_server_sdk/readme.html#jellyfish-connection-configuration). |
There was a problem hiding this comment.
Maybe it would be nicer to put the description in Client moduledoc?
3 participants
No description provided.