Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 80.00% 82.11% +2.11%
==========================================
Files 18 18
Lines 260 246 -14
==========================================
- Hits 208 202 -6
+ Misses 52 44 -8
Continue to review full report in Codecov by Sentry.
|
Rados13
force-pushed
the
refactor_structure_error
branch
from
a9dd32f to
2dee310
Compare
sgfn
approved these changes
Feb 19, 2024
Comment on lines
+10
to
+11
| require Logger | ||
|
|
Comment on lines
+27
to
+55
| def make_get_request!(client, path) do | ||
| with {:ok, %Env{status: 200, body: body}} <- Tesla.get(client.http_client, path) do | ||
| data = | ||
| case Map.fetch(body, "data") do | ||
| {:ok, data} -> data | ||
| :error -> raise StructureError, body | ||
| end | ||
|
|
||
| {:ok, data} | ||
| else | ||
| error -> handle_response_error(error) | ||
| end | ||
| end | ||
|
|
||
| def make_post_request!(client, path, request_body) do | ||
| with {:ok, %Env{status: 201, body: body}} <- | ||
| Tesla.post(client.http_client, path, request_body) do | ||
| data = | ||
| case Map.fetch(body, "data") do | ||
| {:ok, data} -> data | ||
| :error -> raise StructureError, body | ||
| end | ||
|
|
||
| {:ok, data} | ||
| else | ||
| error -> handle_response_error(error) | ||
| end | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
Nitpick but I suppose we could merge the same parts under a defp make_request!(method, client, path, body)
Co-authored-by: Jakub Pisarek <99591440+sgfn@users.noreply.github.com>
Co-authored-by: Jakub Pisarek <99591440+sgfn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.