Conversation
sgfn
approved these changes
Mar 12, 2024
Rados13
approved these changes
Mar 12, 2024
Comment on lines
+14
to
+19
| @type credentials :: %{ | ||
| access_key_id: String.t(), | ||
| secret_access_key: String.t(), | ||
| region: String.t(), | ||
| bucket: String.t() | ||
| } |
Contributor
There was a problem hiding this comment.
I think we could use the same type as in Component.HLS.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 82.62% 83.01% +0.39%
==========================================
Files 19 20 +1
Lines 259 265 +6
==========================================
+ Hits 214 220 +6
Misses 45 45
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.