Skip to content

Modify Room.add_peer function#63

Merged
Rados13 merged 2 commits intomasterfrom
add_websocket_url
Apr 17, 2024
Merged

Modify Room.add_peer function#63
Rados13 merged 2 commits intomasterfrom
add_websocket_url

Conversation

@Rados13
Copy link
Copy Markdown
Contributor

@Rados13 Rados13 commented Apr 16, 2024

No description provided.

@Rados13 Rados13 self-assigned this Apr 16, 2024
@Rados13 Rados13 marked this pull request as ready for review April 16, 2024 12:36
@Rados13 Rados13 requested review from roznawsk and sgfn April 16, 2024 12:40
Copy link
Copy Markdown
Member

@roznawsk roznawsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Copy link
Copy Markdown
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& good

@Rados13 Rados13 force-pushed the add_websocket_url branch from 45b3ff4 to 7360d8b Compare April 17, 2024 13:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2024

Codecov Report

Merging #63 (b7b793d) into master (8480d29) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   82.77%   82.70%   -0.07%     
==========================================
  Files          20       20              
  Lines         267      266       -1     
==========================================
- Hits          221      220       -1     
  Misses         46       46              
Files Coverage Δ
lib/jellyfish/room.ex 96.20% <100.00%> (-0.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480d29...b7b793d. Read the comment docs.

@Rados13 Rados13 merged commit 5d9d457 into master Apr 17, 2024
@Rados13 Rados13 deleted the add_websocket_url branch April 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants