Skip to content

Add subsrcibe mode to hls component#118

Merged
Karolk99 merged 4 commits intomainfrom
hls-subscirbe-mode
Nov 23, 2023
Merged

Add subsrcibe mode to hls component#118
Karolk99 merged 4 commits intomainfrom
hls-subscirbe-mode

Conversation

@Karolk99
Copy link
Copy Markdown
Contributor

@Karolk99 Karolk99 commented Nov 17, 2023

Acknowledging the stipulations set forth:

  • I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
  • I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

@Karolk99 Karolk99 requested review from Rados13 and sgfn November 17, 2023 12:22
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2023

Codecov Report

Merging #118 (05e8ae1) into main (67620f4) will increase coverage by 0.20%.
Report is 1 commits behind head on main.
The diff coverage is 95.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   86.09%   86.30%   +0.20%     
==========================================
  Files          52       54       +2     
  Lines         971      993      +22     
==========================================
+ Hits          836      857      +21     
- Misses        135      136       +1     
Files Coverage Δ
lib/jellyfish/component/hls.ex 91.30% <100.00%> (+0.39%) ⬆️
lib/jellyfish/room.ex 85.53% <100.00%> (+0.86%) ⬆️
lib/jellyfish_web/api_spec/component/hls.ex 100.00% <ø> (ø)
lib/jellyfish_web/api_spec/subscription.ex 100.00% <100.00%> (ø)
lib/jellyfish_web/router.ex 100.00% <100.00%> (ø)
...llyfish_web/controllers/subscription_controller.ex 88.88% <88.88%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67620f4...05e8ae1. Read the comment docs.

Comment thread lib/jellyfish/room.ex Outdated
Comment thread lib/jellyfish_web/controllers/subscription_controller.ex Outdated
Comment thread lib/jellyfish/room.ex Outdated
Comment thread lib/jellyfish_web/api_spec/component/hls.ex Outdated
Comment thread lib/jellyfish_web/api_spec/component/hls.ex Outdated
Comment thread lib/jellyfish_web/api_spec/subscription.ex Outdated
Comment thread lib/jellyfish_web/controllers/subscription_controller.ex
@Karolk99 Karolk99 marked this pull request as ready for review November 21, 2023 16:32
@Karolk99 Karolk99 requested review from Rados13 and sgfn November 21, 2023 16:33
@Karolk99 Karolk99 merged commit d321f5f into main Nov 23, 2023
@Karolk99 Karolk99 deleted the hls-subscirbe-mode branch November 23, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants