Skip to content

Conversation

@grizzi
Copy link
Contributor

@grizzi grizzi commented Oct 17, 2025

I failed to compile the fpsdk_common since I am compiling with clang.

Ubuntu clang version 20.1.8 (++20250708082409+6fb913d3e2ec-1~exp1~20250708202428.132)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-20/bin

This is not a proper solution, but enough to unlock the building. I have seen that there is quite many warning bypasses for eigen in other headers, but this are not directly used by fpsdk_common which is a hard dependency to build the ros2 driver.

@flipflip8952
Copy link
Contributor

Hi
Thanks. The Eigen3 dependency is there because some of the API provided by the Fixposition SDK uses Eigen types (vectors and such). The warning suppression are there to, well, suppress the warnings we'd otherwise get from Eigen headers... :) Likewise there are similar wrapper includes for ROS.

@flipflip8952 flipflip8952 self-assigned this Oct 17, 2025
@flipflip8952 flipflip8952 marked this pull request as draft October 17, 2025 15:08
@grizzi
Copy link
Contributor Author

grizzi commented Oct 20, 2025

Thanks, I understand the logic to suppress the warning. Would it be possible to support also clang based compilation?

@flipflip8952
Copy link
Contributor

Yes, perhaps... I'm getting this for the Debug build:

/usr/include/boost/stacktrace/detail/libbacktrace_impls.hpp:23:13: fatal error: 'backtrace.h' file not found
   23 | #   include <backtrace.h>

Any ideas?

@flipflip8952
Copy link
Contributor

I've added some minimal CI for clang to catch these. I don't know how to add to your existing pull request. Github has created a new PR now with my changes on top of yours: #157

Not sure how this works in Github...

Anyway, now it's building new Docker images that will include clang (19) and that then can run some of the CI for clang.

Note that I don't think we can call Fixposition SDK 100% clang ready, the CI for clang only covers two (out of dozens) of different build configurations.

@flipflip8952
Copy link
Contributor

flipflip8952 commented Oct 20, 2025

SDK should now happily build with clang (CI tests with clang-19, the current default in Debian Trixie).
Closing this. Your changes are included in #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants