Skip to content

Add trivial instances for () and Void#148

Closed
Daniel-Diaz wants to merge 3 commits intofizruk:masterfrom
Daniel-Diaz:master
Closed

Add trivial instances for () and Void#148
Daniel-Diaz wants to merge 3 commits intofizruk:masterfrom
Daniel-Diaz:master

Conversation

@Daniel-Diaz
Copy link
Copy Markdown

These are useful when a function expects a form but no form is to be passed.

I updated the stack file because it otherwise didn't build.

Comment thread src/Web/Internal/FormUrlEncoded.hs Outdated
Comment thread src/Web/Internal/FormUrlEncoded.hs
@Daniel-Diaz
Copy link
Copy Markdown
Author

Any further feedback on this?

@Daniel-Diaz
Copy link
Copy Markdown
Author

Is this looking ready? I can make further changes if required. Thanks.

@phadej
Copy link
Copy Markdown
Collaborator

phadej commented Feb 23, 2025

I won't look at this until GHC-9.12.2 is out. Would come back to this when adding GHC-9.12 support.

@Daniel-Diaz
Copy link
Copy Markdown
Author

I won't look at this until GHC-9.12.2 is out. Would come back to this when adding GHC-9.12 support.

Got it. Thanks!

@Daniel-Diaz
Copy link
Copy Markdown
Author

I won't look at this until GHC-9.12.2 is out. Would come back to this when adding GHC-9.12 support.

Gentle reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants