Cannot download PNG file with iValue.download() method

[ncalaway]

Description

PNG files can't be downloaded using the .download() method. Possibly other files also have this problem. fsWriteSync throws an error that the file signature is invalid.

Steps to reproduce

1. Save an img to a variable using context.exists()
2. call .download on the variable; pass a file path as the first and only argument, saved as a PNG

Expected behavior

File downloaded correctly

Actual behavior

Invalid file signature error thrown; corrupt image file saved to filesystem

[ncalaway]

File signature when catting an image looks like:

�PNG

For both good and invalid PNGs.

[ncalaway]

Jpeg throws Crc error

[ncalaway]

File downloaded via Firefox and file downloaded via Flagpole have differences on every line when both are converted to hex.

[ncalaway]

Stripping out the needle.request() method and using it on its own correctly downloads the file. It is getting corrupted somewhere after that.

[ncalaway]

It is getting corrupted in the process of turning a Needle response into an HttpResponse

[ncalaway]

I think it's because the PNG buffer is being turned into a string with utf8 encoding. It should probably be base64.

[ncalaway]

There is corruption taking place even when I use base64

[ncalaway]

The conversion of buffer to string in the constructor for HttpResponse is responsible for the corruption. What do I break if I take out the call to JSON.stringify()?