Added back BLIS_ENABLE_ZEN_BLOCK_SIZES macro to zen configuration.#573
Merged
fgvanzee merged 1 commit intoflame:masterfrom Dec 7, 2021
Merged
Added back BLIS_ENABLE_ZEN_BLOCK_SIZES macro to zen configuration.#573fgvanzee merged 1 commit intoflame:masterfrom
fgvanzee merged 1 commit intoflame:masterfrom
Conversation
This is same as release 1.3. This was added before to improve DGEMM Multithreaded scalability on Naples for when number of threads is greater than 16. By mistake this got deleted in many changes done for 2.0 release, now we are adding this change back., in bli_gemm_front.c - code clean Change-Id: I6827b58d2dab1041fe182fef5a007b679ac4bb1f
dzambare
pushed a commit
to Meghana-vankadari/blis
that referenced
this pull request
Jan 6, 2022
Details: - Added previously-deleted cpp macro block to bli_cntx_init_zen.c targeting the Naples microarchitecture that enabled different cache blocksizes when the number of threads exceeds 16. This commit represents PR flame#573.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request contains cache-block sizes tuned for AMD Naples system. This was added before to improve DGEMM Multithreaded scalability on Naples for when number of threads is greater than 16. This change was not reflected in public repo, this change seems to be deleted, now we are adding this change back.
Change-Id: I6827b58d2dab1041fe182fef5a007b679ac4bb1f