Test driver fix for her, her2, herk and her2k#578
Merged
fgvanzee merged 6 commits intoflame:masterfrom Nov 17, 2021
Merged
Conversation
Fixed test driver code for her, her2, herk and her2k function. Above functions supports only complex and double complex data type, test code is updated accordingly. Change-Id: Iee7b79abda4a2959a265c420d23879bf47f2c38d AMD-Internal: [CPUPL-1313]
Fixed test driver code for her, her2 Support added to handle complex and double complex data type in test driver. Change-Id: If65939e99d8cf77e0fb70561166d84bf67d0321d AMD-Internal: [CPUPL-1326]
Fixed test driver code for her, her2, herk and her2k function. Above functions supports only complex and double complex data type, test code is updated accordingly. Change-Id: Iee7b79abda4a2959a265c420d23879bf47f2c38d AMD-Internal: [CPUPL-1313]
Fixed test driver code for her, her2 Support added to handle complex and double complex data type in test driver. Change-Id: If65939e99d8cf77e0fb70561166d84bf67d0321d AMD-Internal: [CPUPL-1326]
Details: - Added conditional branches for calling real domain syr, syr2, syrk, and syr2k BLAS interfaces in the test_her.c, test_her2.c, test_herk.c, and test_her2k.c driver files in the 'test' directory.
Member
|
@madanm3 Thanks for your fixes. I added the real domain |
Member
|
PS: I cancelled the Travis CI build since there is no way these changes could affect the library. |
dzambare
pushed a commit
to Meghana-vankadari/blis
that referenced
this pull request
Jan 6, 2022
Details: - Replaced the hard-coded calls to double-precision real syr, syr2, syrk, and syrk in the corresponding standalone test drivers in the 'test' directory with conditional branches that will call the appropriate BLAS interface depending on which datatype is enabled. Thanks to Madan mohan Manokar for this improvement. - CREDITS file update.
fgvanzee
added a commit
that referenced
this pull request
Sep 10, 2022
Details: - Replaced the hard-coded calls to double-precision real syr, syr2, syrk, and syrk in the corresponding standalone test drivers in the 'test' directory with conditional branches that will call the appropriate BLAS interface depending on which datatype is enabled. Thanks to Madan mohan Manokar for this improvement. - CREDITS file update. - (cherry picked from commit 9be97c1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix done driver code.