Skip to content

Fix hobbled multithreaded performance of gemmlike sandbox (and sup when packing) #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgvanzee merged 2 commits into from
Dec 13, 2022
Merged

Fix hobbled multithreaded performance of gemmlike sandbox (and sup when packing) #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e7ed30
Fixed func calls in gemmlike/bls_l3_packm_var?.c.
fgvanzee Dec 10, 2022
d2ff04f
Fixed perf of mt sup with packing, and mt gemmlike.
fgvanzee Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frame/3/bli_l3_sup_packm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ void bli_packm_sup
( void* )a, rs_a, cs_a,
*p, *rs_p, *cs_p,
( cntx_t* )cntx,
thread
bli_thrinfo_sub_prenode( thread )
);
}
else // if ( schema == BLIS_PACKED_ROW_PANELS )
Expand All @@ -415,7 +415,7 @@ void bli_packm_sup
*p, *rs_p, *cs_p,
pd_p, *ps_p,
( cntx_t* )cntx,
thread
bli_thrinfo_sub_prenode( thread )
);
}

Expand Down
9 changes: 9 additions & 0 deletions frame/3/bli_l3_thrinfo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,15 @@ thrinfo_t* bli_l3_sup_thrinfo_create
thrinfo_t* thread_jr = bli_thrinfo_split( n_way_jr, thread_pa );
thrinfo_t* thread_ir = bli_thrinfo_split( n_way_ir, thread_jr );

const dim_t n_way_pb = bli_thrinfo_num_threads( thread_pb );
const dim_t n_way_pa = bli_thrinfo_num_threads( thread_pa );

// Create and set the prenodes for the packb and packa thrinfo_t nodes.
thrinfo_t* thread_pb_single = bli_thrinfo_split( n_way_pb, thread_pb );
thrinfo_t* thread_pa_single = bli_thrinfo_split( n_way_pa, thread_pa );
bli_thrinfo_set_sub_prenode( thread_pb_single, thread_pb );
bli_thrinfo_set_sub_prenode( thread_pa_single, thread_pa );

bli_thrinfo_set_sub_node( thread_jc, root );
bli_thrinfo_set_sub_node( thread_pc, thread_jc );
bli_thrinfo_set_sub_node( thread_pb, thread_pc );
Expand Down
2 changes: 1 addition & 1 deletion sandbox/gemmlike/bls_l3_packm_a.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ void PASTECH2(bls_,ch,opname) \
*p, *rs_p, *cs_p, \
pd_p, *ps_p, \
cntx, \
thread \
bli_thrinfo_sub_prenode( thread ) \
); \
\
/* Barrier so that packing is done before computation. */ \
Expand Down
2 changes: 1 addition & 1 deletion sandbox/gemmlike/bls_l3_packm_b.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ void PASTECH2(bls_,ch,opname) \
*p, *rs_p, *cs_p, \
pd_p, *ps_p, \
cntx, \
thread \
bli_thrinfo_sub_prenode( thread ) \
); \
\
/* Barrier so that packing is done before computation. */ \
Expand Down
4 changes: 2 additions & 2 deletions sandbox/gemmlike/bls_l3_packm_var1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ void PASTECH2(bls_,ch,varname) \
\
/* Query the number of threads and thread ids from the current thread's
packm thrinfo_t node. */ \
const dim_t nt = bli_thrinfo_num_threads( thread ); \
const dim_t tid = bli_thrinfo_thread_id( thread ); \
const dim_t nt = bli_thrinfo_n_way( thread ); \
const dim_t tid = bli_thrinfo_work_id( thread ); \
\
/* Suppress warnings in case tid isn't used (ie: as in slab partitioning). */ \
( void )nt; \
Expand Down
4 changes: 2 additions & 2 deletions sandbox/gemmlike/bls_l3_packm_var2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ void PASTECH2(bls_,ch,varname) \
\
/* Query the number of threads and thread ids from the current thread's
packm thrinfo_t node. */ \
const dim_t nt = bli_thrinfo_num_threads( thread ); \
const dim_t tid = bli_thrinfo_thread_id( thread ); \
const dim_t nt = bli_thrinfo_n_way( thread ); \
const dim_t tid = bli_thrinfo_work_id( thread ); \
\
/* Suppress warnings in case tid isn't used (ie: as in slab partitioning). */ \
( void )nt; \
Expand Down
4 changes: 2 additions & 2 deletions sandbox/gemmlike/bls_l3_packm_var3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ void PASTECH2(bls_,ch,varname) \
\
/* Query the number of threads and thread ids from the current thread's
packm thrinfo_t node. */ \
const dim_t nt = bli_thrinfo_num_threads( thread ); \
const dim_t tid = bli_thrinfo_thread_id( thread ); \
const dim_t nt = bli_thrinfo_n_way( thread ); \
const dim_t tid = bli_thrinfo_work_id( thread ); \
\
/* Suppress warnings in case tid isn't used (ie: as in slab partitioning). */ \
( void )nt; \
Expand Down