Do not use symbol aliases on macOS.#856
Merged
devinamatthews merged 2 commits intomasterfrom Feb 19, 2025
Merged
Conversation
Details: - The BLAS/CBLAS function `?gemmtr` is currently implemented as a symbol alias of the already-existing `?gemmt`. This does not work on macOS/Darwin. - Instead, duplicate the entire BLAS function with the new name, and use a minimal wrapper function for CBLAS. - Also clean up the CBLAS prototypes a bit.
devinamatthews
added a commit
that referenced
this pull request
Jun 7, 2025
Details: - The BLAS/CBLAS function `?gemmtr` is currently implemented as a symbol alias of the already-existing `?gemmt`. This does not work on macOS/Darwin. - Instead, use a minimal wrapper function which calls the appropriate existing BLAS/CBLAS function. - Also clean up the CBLAS prototypes a bit. (cherry picked from commit 14047f6)
devinamatthews
added a commit
that referenced
this pull request
Jun 7, 2025
Details: - The BLAS/CBLAS function `?gemmtr` is currently implemented as a symbol alias of the already-existing `?gemmt`. This does not work on macOS/Darwin. - Instead, use a minimal wrapper function which calls the appropriate existing BLAS/CBLAS function. - Also clean up the CBLAS prototypes a bit. (cherry picked from commit 14047f6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
?gemmtris currently implemented as a symbol alias of the already-existing?gemmt. This does not work on macOS/Darwin.?gemmt/?cblas_gemmt, but only on macOS.