Fix check for SVE instructions which caused problems on Windows.#859
Merged
devinamatthews merged 2 commits intomasterfrom Mar 2, 2025
Merged
Fix check for SVE instructions which caused problems on Windows.#859devinamatthews merged 2 commits intomasterfrom
devinamatthews merged 2 commits intomasterfrom
Conversation
Details: - The context intialization for `armsve` was using the HWCAP functionality of Linux to check if SVE instructions are actually available, since these are used to determine the register blocksizes. Naturally, this causes problems on Windows. - Instead, use functions from `bli_cpuid.c` to check for SVE. On Windows, no check is actually done and SVE is never detected. - In the case that the user specifically requests the `armsve` config on Windows, only enable this check for the whole `arm64` family and just assume SVE is available otherwise.
devinamatthews
added a commit
that referenced
this pull request
Jun 7, 2025
* Fix check for SVE instructions which caused problems on Windows. Details: - The context intialization for `armsve` was using the HWCAP functionality of Linux to check if SVE instructions are actually available, since these are used to determine the register blocksizes. Naturally, this causes problems on Windows. - Instead, use functions from `bli_cpuid.c` to check for SVE. On Windows, no check is actually done and SVE is never detected. - In the case that the user specifically requests the `armsve` config on Windows, only enable this check for the whole `arm64` family and just assume SVE is available otherwise. * Blacklist armsve on Windows. (cherry picked from commit 37e52a6)
devinamatthews
added a commit
that referenced
this pull request
Jun 7, 2025
* Fix check for SVE instructions which caused problems on Windows. Details: - The context intialization for `armsve` was using the HWCAP functionality of Linux to check if SVE instructions are actually available, since these are used to determine the register blocksizes. Naturally, this causes problems on Windows. - Instead, use functions from `bli_cpuid.c` to check for SVE. On Windows, no check is actually done and SVE is never detected. - In the case that the user specifically requests the `armsve` config on Windows, only enable this check for the whole `arm64` family and just assume SVE is available otherwise. * Blacklist armsve on Windows. (cherry picked from commit 37e52a6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
armsvewas using the HWCAP functionality of Linux to check if SVE instructions are actually available, since these are used to determine the register blocksizes. Naturally, this causes problems on Windows.bli_cpuid.cto check for SVE. On Windows, no check is actually done and SVE is never detected.armsveconfig on Windows, only enable this check for the wholearm64family and just assume SVE is available otherwise.armsvehas been blacklisted for Windows due to other compilation issues.