Fix problem in bli_obj_imag_part.#861
Merged
devinamatthews merged 1 commit intomasterfrom Mar 2, 2025
Merged
Conversation
Details: - When adjusting the buffer to point to the first imaginary element, the function `bli_obj_buffer_at_off` was used which includes and currently set offsets, but then `bli_obj_set_buffer` was used which is the offset *before* applying offsets. - Now a matching `bli_obj_buffer` is used to avoid any offsets.
devinamatthews
added a commit
that referenced
this pull request
Jun 7, 2025
Details: - When adjusting the buffer to point to the first imaginary element, the function `bli_obj_buffer_at_off` was used which includes and currently set offsets, but then `bli_obj_set_buffer` was used which is the offset *before* applying offsets. - Now a matching `bli_obj_buffer` call is used to avoid any offsets. (cherry picked from commit 97084c7)
devinamatthews
added a commit
that referenced
this pull request
Jun 7, 2025
Details: - When adjusting the buffer to point to the first imaginary element, the function `bli_obj_buffer_at_off` was used which includes and currently set offsets, but then `bli_obj_set_buffer` was used which is the offset *before* applying offsets. - Now a matching `bli_obj_buffer` call is used to avoid any offsets. (cherry picked from commit 97084c7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
bli_obj_buffer_at_offwas used which includes any currently set offsets, but thenbli_obj_set_bufferwas used which is the buffer before applying offsets.bli_obj_bufferis used to avoid any offsets.