Consider rlib targets in addition to lib targets#430
Merged
djc merged 2 commits intoflamegraph-rs:mainfrom Jan 30, 2026
Merged
Conversation
djc
approved these changes
Jan 29, 2026
Contributor
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
LGTM! Curious what you're benchmarking...
Contributor
Author
|
This came up with zk-cred-longfellow. We customized |
djc
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes target filtering in cargo-flamegraph to consider
TargetKind::Rlibin addition toTargetKind::Lib. If thecrate-typemetadata has been customized, such that it no longer contains the default oflib, this affects theTargetKindseen in the list of targets produced bycargo metadata. Thelibcrate type acts as an alias for a different library type, depending on context. Thus, we should considerrlibtargets when trying to run unit tests, just as we considerlib. The--unit-test-kindCLI option still has possible values ofbinandlib, but the latter now checks for both kinds of library targets. This closes #422. I have tested this on crates with acrate-typethat includeslib,rlib, and both.