Skip to content

fix: match plugin updater parity#1

Merged
flamerged merged 1 commit into
mainfrom
fix/updater-parity-setup-status
May 15, 2026
Merged

fix: match plugin updater parity#1
flamerged merged 1 commit into
mainfrom
fix/updater-parity-setup-status

Conversation

@flamerged
Copy link
Copy Markdown
Owner

@flamerged flamerged commented May 14, 2026

Summary

  • restore agent-watch/menutube parity for update UI: copied release installs show release status and script updater; source/dev installs show git metadata and git update guidance only
  • keep GitHub CLI setup/auth status visible under the GitHub Watch section
  • add smoke coverage for source-vs-copied updater behavior

Validation

  • ./scripts/check.sh
  • live source/dev menu render shows no release updater and shows gh auth in green
  • copied temp plugin render shows release updater and no git-update guidance

Note: main branch admin enforcement is now enabled so admin pushes should not bypass branch protection.

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated README to clarify development vs. release installation workflows
  • Improvements

    • Version display now adapts based on installation type: development installs show simplified version with git update guidance, while release installs display version with release status checks
  • Tests

    • Added validation for installation type-specific output behavior

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 36491455-f6e1-46cf-b441-415382b3e69c

📥 Commits

Reviewing files that changed from the base of the PR and between 30d854b and 8187c70.

📒 Files selected for processing (3)
  • README.md
  • bin/github-watch.5m.sh
  • scripts/check.sh

📝 Walkthrough

Walkthrough

The PR introduces conditional release checks in the plugin: release status and update prompts are shown only for copied release installs, while git checkouts skip release checks and display git-based update guidance instead. Tests validate the distinct output paths, and documentation clarifies the install type differences.

Changes

Conditional release checks for git checkouts vs release installs

Layer / File(s) Summary
Conditional release check and update guidance
bin/github-watch.5m.sh
The print_plugin_rows function now branches on whether the plugin is running from a git checkout or copied release install. For git checkouts, it skips release checks and shows git update guidance; for release installs, it computes and renders release status with update prompts.
Test validation and documentation
scripts/check.sh, README.md
Tests in check.sh assert that release output omits git-update guidance and skips "Update to latest release" prompts, while source checkouts behave oppositely. README documentation clarifies symlink development installs versus copied release installs and when menu updater is shown.

Sequence Diagram(s)

No sequence diagram generated: this change is a conditional logic update within a single component, not a multi-component interaction flow.

🎯 2 (Simple) | ⏱️ ~10 minutes

🐰 A symlink or copy—the choice unfolds,
Release checks quiet where git truth holds,
Update guidance shifts with each install's way,
Tests ensure both paths lead astray! 🔄

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: match plugin updater parity' accurately summarizes the main change: establishing parity between agent-watch and menutube for update UI behavior based on installation type (copied vs source/dev).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/updater-parity-setup-status

Comment @coderabbitai help to get the list of available commands and usage tips.

@flamerged flamerged assigned flamerged and unassigned flamerged May 15, 2026
@flamerged flamerged merged commit 86273a1 into main May 15, 2026
4 checks passed
@flamerged flamerged deleted the fix/updater-parity-setup-status branch May 15, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant