This repository was archived by the owner on Oct 25, 2024. It is now read-only.
builder: only build on top of first payload attributes event as it should be canonical #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
approved these changes
Apr 12, 2023
avalonche
approved these changes
Apr 12, 2023
Contributor
|
Should a flag be added to allow different configurations allowing builders to build on late blocks? |
avalonche
reviewed
Apr 12, 2023
| } | ||
|
|
||
| func NewBuilder(sk *bls.SecretKey, ds flashbotsextra.IDatabaseService, relay IRelay, builderSigningDomain boostTypes.Domain, eth IEthereumService, dryRun bool, validator *blockvalidation.BlockValidationAPI, beaconClient IBeaconClient) *Builder { | ||
| func NewBuilder(sk *bls.SecretKey, ds flashbotsextra.IDatabaseService, relay IRelay, builderSigningDomain boostTypes.Domain, eth IEthereumService, dryRun bool, ignoreLatePayloadAttributes bool, validator *blockvalidation.BlockValidationAPI, beaconClient IBeaconClient) *Builder { |
Contributor
There was a problem hiding this comment.
can refactor params to a struct
Collaborator
Author
There was a problem hiding this comment.
We should pass in the config for sure
avalonche
approved these changes
Apr 12, 2023
avalonche
approved these changes
Apr 12, 2023
dvush
added a commit
that referenced
this pull request
Apr 19, 2023
dvush
added a commit
that referenced
this pull request
Jun 2, 2023
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
… as it should be canonical (#62)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Because of how the CL events are set up right now, the builder should ignore subsequent payload attributes calls, as they might be non-canonical. This behaviour on CLs will change in the future and the logic will be adjusted.
📚 References
CONTRIBUTING.md