Save simulated block value to database #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
add-block-value
branch
from
eaed801 to
b8a03e4
Compare
1 task
avalonche
force-pushed
the
add-block-value
branch
from
b8a03e4 to
726f1a2
Compare
metachris
reviewed
Jul 5, 2024
avalonche
force-pushed
the
add-block-value
branch
from
094bd35 to
bb2ff28
Compare
metachris
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds "block value" reflecting the simulated block value (as opposed to the block's bid value) to the block validation api. This is then saved to the relay db, but it is not exposed in the data api.
⛱ Motivation and Context
Improve transparency and data collection by saving a bid's true block value after simulation. This allows more visibility into builder subsidies in blocks.
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md