This repository was archived by the owner on Nov 27, 2024. It is now read-only.
update FAQ to reflect low priority of backfill tasks on dramatiq#293
Open
pintail-xyz wants to merge 1 commit intoflashbots:mainfrom
Open
update FAQ to reflect low priority of backfill tasks on dramatiq#293pintail-xyz wants to merge 1 commit intoflashbots:mainfrom
pintail-xyz wants to merge 1 commit intoflashbots:mainfrom
Conversation
gheise
reviewed
Apr 28, 2022
Contributor
gheise
left a comment
gheise
left a comment
There was a problem hiding this comment.
If you'd like to add the high priority as well, feel free to! Thanks for catching this by the way, very helpful. We are looking to improve our documentation as time permits
| For messages failed and waiting to retry in the delay queue (DQ), query: | ||
| ``` | ||
| HGETALL dramatiq:default.DQ.msgs | ||
| HGETALL dramatiq:low.DQ.msgs |
Contributor
There was a problem hiding this comment.
In reality, tasks sent from the listener are high priority, while tasks queued manually are low priority, so there are two delay queues and X queues.
| DEL dramatiq:default.msgs | ||
| DEL dramatiq:default.DQ.msgs | ||
| DEL dramatiq:low.msgs | ||
| DEL dramatiq:low.DQ.msgs |
Contributor
There was a problem hiding this comment.
Same applies here: deleting backfill tasks:
DEL "dramatiq:low.msgs"
deleting listener tasks:
DEL "dramatiq:high.msgs"
| For total messages, query: | ||
| ``` | ||
| HLEN dramatiq:default.msgs | ||
| HLEN dramatiq:low.msgs |
Contributor
There was a problem hiding this comment.
Missing quotes around the ZSET, "dramatiq:low.msgs"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Commit 1fbecbe changed the priority of worker tasks on dramtiq, so the FAQ instructions for redis need updating.
Related issue
294
Testing
I tested these commands on my own system. With
defaultpriority, no messages were returned. Withlowpriority, all the expected messages about runningbackfilltasks were returned.Checklist before merging
./mev test