Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

decode: collapse tuples#94

Merged
lukevs merged 3 commits intoflashbots:mainfrom
come-maiz:issue/tuple
Oct 12, 2021
Merged

decode: collapse tuples#94
lukevs merged 3 commits intoflashbots:mainfrom
come-maiz:issue/tuple

Conversation

@come-maiz
Copy link
Copy Markdown

Closes #93.

@lukevs
Copy link
Copy Markdown
Collaborator

lukevs commented Oct 11, 2021

🔥 great find

only comment is it looks like pre-commit isn’t installed (it would change single to double quotes and some other things). there should be setup instructions in the README

That should cause a PR build failure. I’ll check to see why that’s not happening

@come-maiz
Copy link
Copy Markdown
Author

@lukevs done! Thanks for the review.

@come-maiz
Copy link
Copy Markdown
Author

oh wait

@come-maiz
Copy link
Copy Markdown
Author

done!

Copy link
Copy Markdown
Collaborator

@lukevs lukevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@lukevs lukevs merged commit 1c1b807 into flashbots:main Oct 12, 2021
mendesfabio pushed a commit to mendesfabio/mev-inspect-py that referenced this pull request Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to classify an ABI function with a tuple argument

2 participants