fix: override clap long version envs#235
Merged
SozinM merged 1 commit intoflashbots:mainfrom Aug 20, 2025
Merged
Conversation
julio4
requested review from
SozinM,
avalonche,
ferranbt and
karim-agha
as code owners
SozinM
approved these changes
Aug 14, 2025
This was referenced Jan 17, 2026
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
#52 introduced build time environment variables for extra metrics, similar to what is done in reth.
Clap long version (--version) configuration was not overridden and was using by default the one used by eth.
This PR is a fix to this by using the correct envs.