fix(flashblocks): gracefull cancellation on payload build failure#239
Merged
avalonche merged 1 commit intoflashbots:mainfrom Sep 11, 2025
Merged
Conversation
Collaborator
|
I think with this we still won't get insight into the error we got |
Member
Author
We do log the error here |
avalonche
approved these changes
Sep 11, 2025
This was referenced Jan 17, 2026
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Close #209
Within a payload building job in flashblocks mode, we sequentially build flashblocks and a timer task coordinate timing of building these flashblocks. When a flashblock building fails, the whole payload building job fails and we need to gracefully shutdown all tasks related to this job. This is implemented by cancelling the payload building job cancellation token on flashblock building error, which correctly signal to the associated timer task to shutdown itself.
💡 Motivation and Context
The channel between timer task to coordinate flashblock building was not gracefully shutdown when payload building fail, causing unwanted error and logs.
✅ I have completed the following steps:
make lintmake test