Skip to content

Add remote quote provider arg for flashtestations#276

Merged
avalonche merged 1 commit intomainfrom
quote-provider
Sep 25, 2025
Merged

Add remote quote provider arg for flashtestations#276
avalonche merged 1 commit intomainfrom
quote-provider

Conversation

@avalonche
Copy link
Collaborator

📝 Summary

  • Replaces --debug-url with --quote_provider arg

💡 Motivation and Context

Allow the external tdx provider to fetch attestations


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

env = "FLASHTESTATIONS_DEBUG_TEE_KEY_SEED",
default_value = "debug"
)]
pub debug_tee_key_seed: String,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Option?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also mark somehow that it's not for production

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has a default value and won't be used if debug not enabled so it won't be a required arg. Option will be same logic by having .unwrap_else("debug")

@avalonche avalonche merged commit 83f9cee into main Sep 25, 2025
4 checks passed
@avalonche avalonche deleted the quote-provider branch September 25, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants