chore: add unused_async clippy lint, deny unreachable_pub#299
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances code quality by adding stricter linting rules: the unused_async clippy lint to catch unnecessary async functions, and upgrading unreachable_pub from warn to deny to enforce proper visibility modifiers.
- Added
unused_asyncclippy lint to warn about unnecessary async functions - Changed
unreachable_publint level from warn to deny - Removed unnecessary
asynckeyword fromgenerate_genesisfunction
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Added unused_async clippy lint and changed unreachable_pub to deny level |
| crates/op-rbuilder/src/tests/framework/apis.rs | Removed unnecessary async modifier from generate_genesis function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
akundaz
approved these changes
Oct 17, 2025
This was referenced Jan 17, 2026
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
unused_asyncclippy lintunreachable_pub; this previously was not being caught by CI, as it's a rust lint, and the CI was runningmake lintand only denying on clippy warnings💡 Motivation and Context
code quality
✅ I have completed the following steps:
make lintmake test