Merged
Conversation
0edf0b4 to
d6aba9d
Compare
e6a1d0a to
7c1d189
Compare
255498d to
6438e60
Compare
ferranbt
reviewed
Jun 5, 2025
crates/op-rbuilder/src/launcher.rs
Outdated
| @@ -0,0 +1,149 @@ | |||
| use super::{ | |||
Contributor
There was a problem hiding this comment.
Can we keep this launcher on main.rs?
Collaborator
Author
There was a problem hiding this comment.
Sure, moved that to the main.rs 👌
ferranbt
reviewed
Jun 5, 2025
crates/op-rbuilder/src/args/mod.rs
Outdated
| /// Returns the type of builder implementation that the node is started with. | ||
| /// Currently supports `Standard` and `Flashblocks` modes. | ||
| fn builder_mode(&self) -> BuilderMode { | ||
| fn builder_mode(&self) -> Option<BuilderMode> { |
Contributor
There was a problem hiding this comment.
Can we revert this change? We want to default for now to Standard if nothing else is set.
Collaborator
Author
There was a problem hiding this comment.
Ok, reverted and also squashed commits.
29e414e to
68e83c9
Compare
68e83c9 to
dcadfb7
Compare
karim-agha
approved these changes
Jun 5, 2025
SozinM
approved these changes
Jun 5, 2025
This was referenced Jan 17, 2026
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OpenTelemetry support. To use it, activate
--feature=telemetry. A feature gate is used to avoid integrating allopentelemetrydependencies when they’re not needed.Key changes: since access to the tracing layer requires
CliApp(which isCliwith additional configuration fields), the.configure()method is used after parsing parameters.CliAppalso uses theLaunchertrait, allowing different types to configure the launch process. In our case, the launcher is implemented as a struct instead of a closure, and there's an emptyLauncherfor other (non-node) commands, asrethcurrently doesn’t allow omitting the launcher even when it’s not needed.To run, you can try:
Than open http://localhost:16686/
✅ I have completed the following steps:
make lintmake test