fix: remove ws publishing from synced flashblocks#312
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes WebSocket publishing functionality from the synced flashblocks code path. The change eliminates the ws_pub parameter and its associated publishing logic when handling synced flashblocks, while keeping the execution and payload event handling intact.
Key Changes:
- Removed
WebSocketPublisherdependency and parameter passing through the payload handler - Eliminated WebSocket publishing code block and related metrics recording for synced flashblocks
- Cleaned up unused
metrics()accessor method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/op-rbuilder/src/builders/flashblocks/service.rs | Removed ws_pub parameter from PayloadHandler initialization |
| crates/op-rbuilder/src/builders/flashblocks/payload_handler.rs | Removed WebSocketPublisher import, struct field, constructor parameter, and publishing logic from payload execution handler |
| crates/op-rbuilder/src/builders/flashblocks/ctx.rs | Removed unused metrics() accessor method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SozinM
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
removal of logic in #310
💡 Motivation and Context
we don't want non-active builders to publish flashblocks to ws, as it requires additional rollup-boost changes.
✅ I have completed the following steps:
make lintmake test