Conversation
noot
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the dependency from the full rollup-boost crate to the lighter rollup-boost-types crate, which contains only the necessary type definitions. This reduces build overhead by avoiding compilation of the entire rollup-boost codebase when only type definitions are needed.
Key changes:
- Replaced
rollup-boostdependency withrollup-boost-typesusing a specific git revision - Updated import paths to reference the new crate structure with module-qualified paths
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updated workspace dependency from rollup-boost to rollup-boost-types with git revision |
| crates/op-rbuilder/Cargo.toml | Replaced rollup-boost dependency with rollup-boost-types |
| crates/op-rbuilder/src/tests/framework/instance.rs | Updated import path for FlashblocksPayloadV1 to use rollup-boost-types |
| crates/op-rbuilder/src/tests/framework/driver.rs | Updated import path for OpExecutionPayloadEnvelope to use rollup-boost-types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The dependency can be removed due to #328, can you import from op-alloy instead? |
noot
changed the title
|
@avalonche done! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 Summary
use op-alloy types for necessary types instead of importing all of rollup-boost.
💡 Motivation and Context
don't need to pull and build all of rollup-boost for a few types anymore :D
✅ I have completed the following steps:
make lintmake test