metrics: instrument flashblock build and wait-for-next-tick by index#388
Open
teddyknox wants to merge 1 commit intoflashbots:mainfrom
Open
metrics: instrument flashblock build and wait-for-next-tick by index#388teddyknox wants to merge 1 commit intoflashbots:mainfrom
teddyknox wants to merge 1 commit intoflashbots:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional flashblock-related metrics to improve observability by tracking build latency and emission counts segmented by flashblock index.
Changes:
- Record a per-flashblock-index histogram for flashblock build duration (
op_rbuilder_flashblock_build_duration_seconds_by_index). - Record a per-flashblock-index counter for emitted flashblocks (
op_rbuilder_flashblock_emitted_total).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3df0ad6 to
181f427
Compare
181f427 to
f52ff56
Compare
f52ff56 to
5f029ed
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
crates/op-rbuilder/src/metrics.rs:87
- The PR description does not mention the addition of wait-for-next-tick metrics, but the code adds three new wait-related metrics:
flashblock_wait_for_next_tick_duration(histogram),flashblock_wait_for_next_tick_gauge(gauge), andop_rbuilder_flashblock_wait_for_next_tick_duration_by_index(histogram). Consider updating the PR description to accurately reflect all metrics being added.
/// Histogram of the time taken to sync a Flashblock
pub flashblock_sync_duration: Histogram,
/// Flashblock UTF8 payload byte size histogram
pub flashblock_byte_size_histogram: Histogram,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@teddyknox reth recently merged changes to metrics paradigmxyz/reth#20232 |
5f029ed to
6a0b6d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
op_rbuilder_flashblock_build_duration_by_index)op_rbuilder_flashblock_wait_for_next_tick_duration)Test plan
cargo check -p op-rbuilderpasses🤖 Generated with Claude Code