Skip to content

Hotfix: pin nightly version to resolve str::as_str() regression #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julio4 merged 2 commits into from
Feb 24, 2026
Merged

Hotfix: pin nightly version to resolve str::as_str() regression #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e97a157
pin ci nighlty version 21-02
julio4 Feb 23, 2026
76449a8
fix: override toolchain matrix to fixed nightly string
julio4 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows/op_rbuilder_checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,11 @@ env:

jobs:
lint_and_test:
name: Lint and test
name: Lint and test (nightly)
runs-on: warp-ubuntu-latest-x64-16x
env:
# Set features for the Makefile
FEATURES: ${{ matrix.features }}
strategy:
matrix:
toolchain:
- nightly
features:
- ""
FEATURES: ""

steps:
- name: Checkout sources
Expand All @@ -32,7 +26,7 @@ jobs:
- name: Setup rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
toolchain: ${{ matrix.toolchain }}
toolchain: nightly-2026-02-21
components: "rustfmt,clippy"

# https://github.com/swatinem/rust-cache
Expand Down
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ docker-image-rbuilder: ## Build a rbuilder Docker image

.PHONY: lint
lint: ## Run the linters
cargo +nightly fmt -- --check
cargo +nightly clippy --all-features -- -D warnings
cargo +nightly-2026-02-21 fmt -- --check
cargo +nightly-2026-02-21 clippy --all-features -- -D warnings

.PHONY: test
test: ## Run the tests for rbuilder and op-rbuilder
Expand All @@ -90,9 +90,9 @@ lt: lint test ## Run "lint" and "test"

.PHONY: fmt
fmt: ## Format the code
cargo +nightly fmt
cargo +nightly clippy --all-features --fix --allow-staged --allow-dirty
cargo +nightly fix --allow-staged --allow-dirty
cargo +nightly-2026-02-21 fmt
cargo +nightly-2026-02-21 clippy --all-features --fix --allow-staged --allow-dirty
cargo +nightly-2026-02-21 fix --allow-staged --allow-dirty

.PHONY: bench
bench: ## Run benchmarks
Expand Down
Loading