fix: loosen bounds on CheckpointContext so we can override it#105
fix: loosen bounds on CheckpointContext so we can override it#105
Conversation
julio4
left a comment
There was a problem hiding this comment.
I see the issue but we still want to make context accessible in build_payload (as introduced in #97).
If we loosen bounds here we should find a way to still pass extra context info to build payload, maybe not as CheckpointContext?
What is the use case for passing extra context info build payload? |
Being able to reuse some already computed infos to construct final payload (such as receipts). Atleast that's the idea |
Honestly this is pretty vague to me... do you have a code reference to us doing this anywhere or a doc detailing this requirement? unichain-builder being able to compile from the latest rblib commit is a top priority |
This is a feature we want because right now the => Having a way to share parts of the computation artifacts of checkpoints to the build payload function will allows platforms to implement performant final payload building. But I agree for unichain-builder close feedback loop on last main commit, we can revert the changes after confirming how it is currently used and find a similar way that don't reduce platform flexibility too much. |
julio4
left a comment
There was a problem hiding this comment.
let's merge it for now and revisit with an alternative solution
The restriction introduced in #97 meant that we can't define our own custom checkpoint context when using the optimism platform functions.
See flashbots/unichain-builder#55