Merged
Conversation
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
So config is before kontroller, as it is more natural to reader. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
It's use has been removed in a3c4094. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
invidian/further-improvements
branch
from
3f9fb32 to
4c1d5f5
Compare
This also prevents code from panicking when creating operator instance using fake client in tests. Also create events client in operator namespace, instead of using global namespaces, as otherwise publishing events is broken and add test to verify events publishing. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
This suppose to be removed in a35ae32. This field is no longer used. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
So it is not stored in a struct, as this value is not shared in any way, but it's just initialized when it's needed. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
So we get more information in case of a failure. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
invidian/further-improvements
branch
from
4c1d5f5 to
0cb7b72
Compare
This is a step to resolve #141. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Instead, run operator and wait until it finishes the cycle. Part of #141 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
So they can be clearly adjusted in tests. WIP, still need to add tests for default values. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Closes #141 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
invidian/further-improvements
branch
from
d19ed80 to
e8f68f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking some experience from #116, this PR improves operator code and it's tests.
Closes #141