git+ssh make flathub bot stuck at downloading

[catsout]

From:
https://github.com/npm/arborist/blob/d9c603ede4fefb0bda1385e70b431b3adec810bf/lib/shrinkwrap.js#L704

Now npm will resolve any github url to git+ssh.
But this will make flathub bot stuck at downloading:
flathub/com.getmailspring.Mailspring#2 (comment)
flathub/net.cozic.joplin_desktop#18 (comment)

As flathub/flathub#2466 (comment), using "ssh" URL like that is bound to fail on flathub: there is no ssh key setup.

So, could we add a option to replace the url, or add some warn messages?

[catsout]

ping @hfiguiere

[hfiguiere]

no idea

[olof-nord]

In case someone comes across this later: the node flatpak-builder-tools only supports a subset of what npm does.
What should work is the following: (see https://github.com/flatpak/flatpak-builder-tools/blob/master/node/tests/data/packages/minimal-git/package.json)

{
  "name": "@flatpak-node-generator-tests/minimal-git",
  "version": "1.0.0",
  "dependencies": {
    "nop": "https://git@github.com/supershabam/nop.git"
  }
}

[bbhtt]

This should hopefully be fixed with latest node generator. If not you can reopen.