[Bug]: tests are not running parallel in make buildsystems

[lw64]

Checklist

• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.2.2

Flatpak version

1.12.5

How to reproduce

When a module with buildsystem make specifies run-tests true.

Expected Behavior

The test should run in parallel. There should be a -j$(nproc) in the make check command.

Actual Behavior

The test are not running in parallel.

Additional Information

No response

[bbhtt]

I cannot reproduce this with 1.4.4, it is executing make check in parallel:

FB: Running 'flatpak build --die-with-parent --env=FLATPAK_BUILDER_BUILDDIR=/run/build/iproute2 --nofilesystem=host:reset --filesystem=/home/bbhtt/Git/github/flatpaks/test/.flatpak-builder/build/iproute2-1 --bind-mount=/run/build/iproute2=/home/bbhtt/Git/github/flatpaks/test/.flatpak-builder/build/iproute2-1 --build-dir=/run/build/iproute2 --bind-mount=/run/active-build=/home/bbhtt/Git/github/flatpaks/test/.flatpak-builder/build/iproute2-1 --bind-mount=/run/ccache=/home/bbhtt/Git/github/flatpaks/test/.flatpak-builder/ccache --readonly --env=SOURCE_DATE_EPOCH=1758604865 '--env=CFLAGS=-O2 -pipe -g -Wp,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer ' '--env=CXXFLAGS=-O2 -pipe -g -Wp,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer ' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed ' --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --env=FLATPAK_BUILDER_N_JOBS=12 /home/bbhtt/Git/github/flatpaks/test/.flatpak-builder/rofiles/rofiles-uqQcLM make check -j12' on host

See the make_j part here

flatpak-builder/src/builder-module.c

Lines 2201 to 2202 in c2c03c4

	if (!build (app_dir, self->name, context, source_dir, build_dir_relative, test_args, env, error,
	make_cmd, test_arg, make_j ? make_j : skip_arg, NULL))

You can test with this:

app-id: org.flatpak.Hello
runtime: org.freedesktop.Platform
runtime-version: '25.08'
sdk: org.freedesktop.Sdk
finish-args:
  - --socket=x11
modules:
  - name: libmnl
    sources:
      - type: archive
        url: https://www.netfilter.org/projects/libmnl/files/libmnl-1.0.5.tar.bz2
        sha256: 274b9b919ef3152bfb3da3a13c950dd60d6e2bcd54230ffeca298d03b40d0525

  - name: iproute2
    run-tests: true
    make-install-args:
      - PREFIX=${FLATPAK_DEST}
      - SBINDIR=${FLATPAK_DEST}/bin
      - CONFDIR=${FLATPAK_DEST}/etc/iproute2
    sources:
      - type: git
        url: https://git.kernel.org/pub/scm/network/iproute2/iproute2.git
        tag: v6.12.0
        commit: 742fb8a25c8740a1b93251ed33da08a60b8353aa

[bbhtt]

Ah looks like you fixed it 84ed24e