[BUG] `CircleMarker` incorrectly fills with stroke color and has incorrect size

[vitalsh]

What is the bug?

CircleMarker fills the circle with either CircleMarker.color or CircleMarker.borderColor

How can we reproduce it?

Looks like any circle will be filled with the stroke color regardless of the settings/parameters

Do you have a potential solution?

circle_layer.dart : line 104 and 118
this line looks suspicious:
final radiusPaint = paint..strokeWidth = radius;
should probably be:
final radiusPaint = paint..strokeWidth = borderStrokeWidth;

Platforms

Any

Severity

Obtrusive: Prevents normal functioning but causes no errors in the console

[JaffaKetchup]

Thanks for reporting, we'll look into it along with the other issues from v6.
Looks like this issue may have been introduced by #1679, heads up @Alexays (I'm happy to fix, but you might have a reason or way you want to, so just pinging).

[TesteurManiak]

Seems to me like an issue with the base implementation, it uses drawPoints to paint the borders which won't work to create just an outline with empty center, drawCircle with a PaintingStyle.stroke should be the way to go.

[mootw]

can confirm this issue, not sure why i did not pick it up during my review. i think im also seeing incorrect radius on the rendering too.

[JaffaKetchup]

Potentially radius and diameter are being switched up.

[Alexays]

I'm on holiday until Wednesday, I'll be able to look into it from then on, sorry for the breaking changes 🥲

[JaffaKetchup]

Ah, no worries. I'll also take a look into it, but you just might have a preferred method.

[Alexays]

I'll go using drawCircle only if the marker is not filled, in that way we preserve as much a we can the perf improvement of using drawPoint.

[JaffaKetchup]

Not quite sure what you mean, but there's no rush at all!