Merged
Conversation
Member
|
Looks like it should work, as I've done similar things locally. Just need to test on my system to make sure. |
JaffaKetchup
approved these changes
Apr 10, 2022
Member
JaffaKetchup
left a comment
JaffaKetchup
left a comment
There was a problem hiding this comment.
LGTM. Live location screen is still broken, but that's a separate issue (location permission not being requested at correct time due to asynchronous request). Will merge now...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built the example app just now, and had to update some numbers. This pull request makes it compilable without errors or warnings.