add CustomPoint.toOffset#1590
Closed
tlserver wants to merge 1 commit intofleaflet:masterfrom
tlserver:master
Closed
add CustomPoint.toOffset#1590tlserver wants to merge 1 commit intofleaflet:masterfrom tlserver:master
tlserver wants to merge 1 commit intofleaflet:masterfrom
tlserver:master
Conversation
Member
|
Hey @tlserver, thanks for the contribution. Just to avoid breaking changes - @rorystephenson can you add this change manually to #1585 and add @tlserver as co-author for attribution? |
Contributor
|
This is now incorporated in #1585 👍. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding
CustomPoint.toOffset()for consistency with OffsetToCustomPointExtension. With PR #1585, this change need to be moved to point_extension.dart